Add shellcheck to basic features#801
Merged
Merged
Conversation
ljharb
suggested changes
Dec 7, 2016
| default['travis_build_environment']['wget']['version'] = '1.18' | ||
|
|
||
| default['travis_build_environment']['shellcheck_url'] = 'https://s3.amazonaws.com/travis-blue-public/binaries/ubuntu/14.04/x86_64/shellcheck-0.4.4.tar.bz2' | ||
| default['travis_build_environment']['shellcheck_version'] = '0.4.0' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ljharb
approved these changes
Dec 8, 2016
ljharb
left a comment
ljharb
left a comment
Contributor
There was a problem hiding this comment.
Awesome! Will this go out to precise images as well?
Contributor
Author
|
@ljharb Not by default. I'd have to backport it 😐 . I'd rather not backport it. Precise is going away 🔜, although I expect we'll keep it around after EOL ... for some amount of time... |
Contributor
Author
fishilico
added a commit
to fishilico/home-files
that referenced
this pull request
Mar 18, 2018
shellcheck has been provided on Travis-CI since December 2016: - travis-ci/travis-cookbooks#801 - koalaman/shellcheck#1121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.